[nrf fromlist] zperf: moving declaration of variable to top of function #2741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlubos
approved these changes
Apr 10, 2025
Declaration of variables after a label inside a switch statement is a c23 extension, not c99. This results in the following warning when compiling with clang: > .../subsys/net/lib/zperf/zperf_shell.c:912:4: warning: label followed > by a declaration is a C23 extension [-Wc23-extensions] > 912 | int seconds = parse_arg(&i, argc, argv); > | ^ > .../subsys/net/lib/zperf/zperf_shell.c:1145:4: warning: label followed > by a declaration is a C23 extension [-Wc23-extensions] > 1145 | int seconds = parse_arg(&i, argc, argv); > | ^ > 2 warnings generated. There are no practical reasons why the variable should be declared inside the switch statement, therefore move the declaration and place it together with declaration of other variables. Upstream PR #: 88403 Signed-off-by: Torsten Rasmussen <[email protected]>
tejlmand
force-pushed
the
zperf_seconds_declaration_fix
branch
from
540b5a0 to
a09f3d5
Compare
|
nordicjm
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaration of variables after a label inside a switch statement is a c23 extension, not c99.
This results in the following warning when compiling with clang:
There are no practical reasons why the variable should be declared inside the switch statement, therefore move the declaration and place it together with declaration of other variables.
Upstream PR #: 88403